-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miller FFV1 review #119
Miller FFV1 review #119
Conversation
Commit message should explain what is changed and why. Some of these commits use just 1 word. Also i think extenal references should be used carefully in commit messages. Who knows if these URLs will work in 10 years. |
Any comments on the contents of the commits before I rewrite the messages? |
i didnt spot any issues in the content, of course i might spot some in conjuction with new messages or when i look a 2nd time |
the commit messages are updated to be a bit more verbose, please re-review |
nudge :) |
responding to https://mailarchive.ietf.org/arch/msg/cellar/671YjBEqo-vdtrHdUebApfu7t_8